Skip to content

[17.0][FWD] endpoint: forward-port querystring params usage#114

Open
SilvioC2C wants to merge 3 commits into
OCA:17.0from
camptocamp:17.0-endpoint-fwd_querystring_params_usage
Open

[17.0][FWD] endpoint: forward-port querystring params usage#114
SilvioC2C wants to merge 3 commits into
OCA:17.0from
camptocamp:17.0-endpoint-fwd_querystring_params_usage

Conversation

@SilvioC2C
Copy link
Copy Markdown
Contributor

@SilvioC2C SilvioC2C commented Sep 22, 2025

Forward-port of #80

Also includes renaming usages of params to querystring_params

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Sep 22, 2025

Hi @simahawk,
some modules you are maintaining are being modified, check this out!

@SilvioC2C
Copy link
Copy Markdown
Contributor Author

SilvioC2C commented Sep 22, 2025

NB: tests are failing for reasons unrelated to these commits

SilvioC2C added a commit to camptocamp/edi-framework that referenced this pull request Sep 22, 2025
@SilvioC2C
[IMP] edi_endpoint_oca: querystring params usage
84f401a 
Compatibility w/ OCA/web-api#114
@SilvioC2C SilvioC2C mentioned this pull request Sep 22, 2025
Open
simahawk
simahawk requested changes Dec 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a test update?

Comment thread endpoint/models/endpoint_mixin.py
handler = self_with_user._get_handler()
try:
res = handler(request)
# In case the handler does not support params
Copy link
Copy Markdown
Contributor

@simahawk simahawk Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would simply let it fail. Or if you really want you can catch a TypeError and log it. But I would just let it break. Beside, I doubt anyone did ever implement a different handler :)

@SilvioC2C
Copy link
Copy Markdown
Contributor Author

SilvioC2C commented Dec 9, 2025

@simahawk would it be better to make a commit in the v14 PR and port it here, or would suggest a commit here for simplicity?

@simahawk
Copy link
Copy Markdown
Contributor

simahawk commented Dec 9, 2025

we can backport it later

@SilvioC2C SilvioC2C requested a review from simahawk January 12, 2026 15:36
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 17, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dreispt dreispt dreispt approved these changes

@simahawk simahawk Awaiting requested review from simahawk

+2 more reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@jcoux jcoux jcoux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SilvioC2C @OCA-git-bot @simahawk @dreispt @ivantodorovich @jcoux